docs(#2264): adopt Conventional Commits #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DominicLuidold
commented
Apr 18, 2024
DominicLuidold
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | Close #2264 |
- Adds a GitHub Actions workflow (based on amannn/action-semantic-pull-request) validating PR titles for compliance with the Conventional Commits specification.
FYI I have just updated the repo settings to use title + description. |
|
hey @DominicLuidold is this PR ready? :) |
@DjordyKoert unfortunately not yet. The changes to the contributing guide are still a todo. I won't be able to finish this PR until the end of May as I'm currently on a longer vacation. I hope that's fine! |
|
@DominicLuidold no worries! I can also do it myself if my time allows it. Enjoy your vacation 😄 |
DjordyKoert
changed the title
|
Thank you @DominicLuidold for recommending, researching and implementing this! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.